Skip to content

Conversation

phansch
Copy link
Contributor

@phansch phansch commented Dec 14, 2018

cc #3523

@matthiaskrgr
Copy link
Member

Thanks!
r=me once this no longer breaks ci :p

n.b.: maybe it should grep for E0463 instead in case the error message wording changes?

@phansch
Copy link
Contributor Author

phansch commented Dec 14, 2018

Good point, I will change it :)

@phansch phansch force-pushed the make_integration_tests_fail_again branch from 01ab70e to d7ba64e Compare December 14, 2018 20:58
@phansch phansch changed the title Make integration tests fail on 'cant find crate' Make integration tests fail on 'E0463' Dec 14, 2018
@phansch phansch force-pushed the make_integration_tests_fail_again branch from d7ba64e to abab181 Compare December 14, 2018 21:09
@flip1995 flip1995 added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Dec 19, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Dec 19, 2018

@bors r+ this will probably pass after #3546 is through

@bors
Copy link
Contributor

bors commented Dec 19, 2018

📌 Commit abab181 has been approved by oli-obk

bors added a commit that referenced this pull request Dec 19, 2018
…i-obk

Make integration tests fail on 'E0463'

cc #3523
@bors
Copy link
Contributor

bors commented Dec 19, 2018

⌛ Testing commit abab181 with merge ff203b3...

@phansch
Copy link
Contributor Author

phansch commented Dec 19, 2018

@bors are you still there?

@bors
Copy link
Contributor

bors commented Dec 19, 2018

🍰 Target acquired

@phansch
Copy link
Contributor Author

phansch commented Dec 19, 2018

@bors retry

@bors
Copy link
Contributor

bors commented Dec 19, 2018

⌛ Testing commit abab181 with merge 691e5e7...

bors added a commit that referenced this pull request Dec 19, 2018
…i-obk

Make integration tests fail on 'E0463'

cc #3523
@bors
Copy link
Contributor

bors commented Dec 19, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing 691e5e7 to master...

@bors bors merged commit abab181 into rust-lang:master Dec 19, 2018
@phansch phansch deleted the make_integration_tests_fail_again branch December 19, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants